[PATCH] D76201: [TargetLowering] Only demand a rotation's modulo amount bits

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon marked 2 inline comments as done.
RKSimon added inline comments.
Herald added a subscriber: wuzish.


================
Comment at: llvm/test/CodeGen/SystemZ/rot-01.ll:30
 ; CHECK-NEXT:    br %r14
   %mod = urem i64 %amt, 32
 
----------------
@uweigand Should this be 32 or 64?


================
Comment at: llvm/test/CodeGen/SystemZ/rot-02.ll:7
 
 ; Test that AND is not removed when some lower 6 bits are not set.
 define i32 @f1(i32 %val, i32 %amt) {
----------------
@uweigand This comment doesn't seem to match the test - any suggestions?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76201/new/

https://reviews.llvm.org/D76201