[PATCH] D75280: [PowerPC][Future] Add initial support for PC Relative addressing for global values

Amy Kwan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 14 15:34:38 PDT 2020


amyk added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:2543
 /// Returns true if this address is a PC Relative address.
 /// PC Relative addresses are marked with the flag PPCII::MO_PCREL_FLAG.
 bool PPCTargetLowering::SelectAddressPCRel(SDValue N, SDValue &Base) const {
----------------
Does it make sense to also add that it is a PC Relative address if it's marked with the `PPCII::MO_PCREL_FLAG` or if the node opcode is `PPCISD::MAT_PCREL_ADDR`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75280/new/

https://reviews.llvm.org/D75280





More information about the llvm-commits mailing list