[llvm] 18eae33 - [SCEV] Fix usage of invalid IP with FoldingSet

Ehud Katz via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 13 20:13:18 PDT 2020


I see. No problem then, I’ll compose a test case.

On Sat, 14 Mar 2020 at 0:07 Florian Hahn <florian_hahn at apple.com> wrote:

>
>
> On Mar 13, 2020, at 19:03, Ehud Katz via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
> rGfcc2238b8bfb
> <https://github.com/llvm/llvm-project/commit/fcc2238b8bfb9498b46a48d219193de8c00a25a0> broke
> the sanitizer "annotate" tests -
> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/26137/,
> which inherently, I think, seems like a good enough test case.
> rG18eae3312297
> <https://github.com/llvm/llvm-project/commit/18eae3312297cb197a3131f3ad9ca2bebb217415> fixes
> it.
>
>
> Usually the bots should not be the first line of defense, the unit tests
> in the repo should be. The bot might go away or some other changes in other
> parts of LLVM/Clang/Sanitizers may change and hide the failure.
>
> If possible, please try to get a reduced IR test case for the failure.
> This will provide a more solid guard against the error in the future.
>
> Cheers,
> Florian
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200314/e23540cc/attachment.html>


More information about the llvm-commits mailing list