[PATCH] D76109: [ELF] Correct error message when OUTPUT_FORMAT is used

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai marked an inline comment as done.
smeenai added inline comments.


================
Comment at: lld/ELF/ScriptParser.cpp:422
   if (config->emachine == EM_NONE)
-    setError("unknown output format name: " + name);
+    setError("unknown output format name: " + config->bfdname);
   if (s == "elf32-ntradlittlemips" || s == "elf32-ntradbigmips")
----------------
grimar wrote:
> I think we might want to have a test that uses something like 'foobar-freebsd'
> and checks that we print `foobar-freebsd` and not just `foobar` contained in `s`.
Great suggestion. Done in https://github.com/llvm/llvm-project/commit/e890453d6d11


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76109/new/

https://reviews.llvm.org/D76109