[PATCH] D76109: [ELF] Correct error message when OUTPUT_FORMAT is used
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 13 02:15:37 PDT 2020
grimar added inline comments.
================
Comment at: lld/ELF/ScriptParser.cpp:422
if (config->emachine == EM_NONE)
- setError("unknown output format name: " + name);
+ setError("unknown output format name: " + config->bfdname);
if (s == "elf32-ntradlittlemips" || s == "elf32-ntradbigmips")
----------------
I think we might want to have a test that uses something like 'foobar-freebsd'
and checks that we print `foobar-freebsd` and not just `foobar` contained in `s`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76109/new/
https://reviews.llvm.org/D76109
More information about the llvm-commits
mailing list