[PATCH] D73086: [WIP][DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump.

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX added inline comments.


================
Comment at: llvm/test/DebugInfo/X86/debug-macro-v5.s:7
+
+# CHECK:.debug_macro contents:
+# CHECK-NEXT:0x00000000:
----------------
jhenderson wrote:
> SouraVX wrote:
> > jhenderson wrote:
> > > `#      CHECK:.debug_macro contents:`
> > > 
> > > same below for the other `CHECK:` line.
> > Is spacing the you're concerned about here ?
> Right. It allows easier reading of the line, because it lines up the actual content being checked with the rest of the content from the subsequent CHECK-NEXT lines.
To avoid same mistakes again, and avoiding confusion -- Following modification you're suggesting -

`#  CHECK:.debug_macro contents:` -- CHECK pattern(1 leading space) in all test cases
should modified be modified with "2" leading spaces in all test cases i.e 
`#    CHECK:debug_macro `
and like wise in subsequent `CHECK-NEXT` ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73086/new/

https://reviews.llvm.org/D73086