[PATCH] D75519: [ExpandMemCmp] Properly constant-fold all compares.

Mon Mar 9 01:02:34 PDT 2020

courbet added a comment.

Thanks.

In D75519#1909956 <https://reviews.llvm.org/D75519#1909956>, @spatel wrote:

> In D75519#1909488 <https://reviews.llvm.org/D75519#1909488>, @courbet wrote:
>
> > Simplify instructions after expandmemcmp.
>
>
> LGTM, but as a matter of risk reduction, please make that an independent commit.

Will do.

> I don't think it would be noticeable, but there is some non-zero compile-time cost in doing that analysis/transform (although it might pay for itself if it makes later codegen faster).
> 
> I don't have a preference for order of landing the changes, but if I'm seeing it correctly, if we land the simplify commit later, it would only cause benign (different label names) diffs in the asm tests.

There is actually a diff in the powerpc test that compares two constants.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75519/new/

https://reviews.llvm.org/D75519