[PATCH] D74338: [RFC][TableGen] Support combining AssemblerPredicates with ORs
Simon Cook via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 13 05:46:33 PDT 2020
simoncook marked an inline comment as done.
simoncook added a comment.
In D74338#1915415 <https://reviews.llvm.org/D74338#1915415>, @evandro wrote:
> It'd be nice if a single predicate wouldn't need `all_of`, but I don't feel strongly about it.
I was thinking about this when implementing the patch originally. I opted against that because it would be unlike other uses of dags in TableGen. I'm thinking in particular about RegisterClasses, where even for just a "stack pointer register class" we still do `(add R2)` in the definition.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74338/new/
https://reviews.llvm.org/D74338
More information about the llvm-commits
mailing list