[PATCH] D75382: [lld] Initial commit for new Mach-O backend
Shoaib Meenai via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 12 11:59:28 PDT 2020
smeenai added inline comments.
================
Comment at: lld/MachO/InputFiles.cpp:141
+
+ObjFile::ObjFile(MemoryBufferRef mb) : InputFile(ObjKind, mb) {
+ auto *buf = (const uint8_t *)mb.getBufferStart();
----------------
int3 wrote:
> ruiu wrote:
> > nit: ObjKind -> objKind
> hm this is an enum value, not a member/parameter, so I think CamelCase is correct here?
Yeah `ObjKind` is consistent with LLD ELF.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75382/new/
https://reviews.llvm.org/D75382
More information about the llvm-commits
mailing list