[PATCH] D75382: [lld] Initial commit for new Mach-O backend
Jez Ng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 12 11:56:22 PDT 2020
int3 marked an inline comment as done.
int3 added a comment.
Thanks everyone for the reviews and suggestions!
================
Comment at: lld/MachO/InputFiles.cpp:141
+
+ObjFile::ObjFile(MemoryBufferRef mb) : InputFile(ObjKind, mb) {
+ auto *buf = (const uint8_t *)mb.getBufferStart();
----------------
ruiu wrote:
> nit: ObjKind -> objKind
hm this is an enum value, not a member/parameter, so I think CamelCase is correct here?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75382/new/
https://reviews.llvm.org/D75382
More information about the llvm-commits
mailing list