[PATCH] D75847: [DAGCombine] Skip PostInc combine with later users
Sam Parker via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 12 03:03:25 PDT 2020
samparker marked an inline comment as done.
samparker added inline comments.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:14189
+ // there are later users which could do it instead.
+ if (isa<MemSDNode>(Use)) {
+ Worklist.push_back(Use);
----------------
dmgreen wrote:
> Should we also be checking that this Use can use some addressing mode and fold the offset in? Not that it just is a memory operation?
Yeah, I shouldn't have been lazy.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75847/new/
https://reviews.llvm.org/D75847
More information about the llvm-commits
mailing list