[PATCH] D75833: [RISCV] Support RISC-V ELF attribute section in llvm-readobj

[Hsiangkai Wang via Phabricator via llvm-commits]

HsiangKai marked an inline comment as done.
HsiangKai added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/RISCV/unknown-arch-attr.test:44
+# The content is the encoding of the arch feature "rv32i2p0_x1p0_m2p0"
+    Content: 412300000072697363760001190000000572763332693270305F783170305F6D32703000
----------------
MaskRay wrote:
> `unittests/Support/RISCVAttributeParser.cpp` is more suitable for such tests. See `unittests/Support/ARMAttributeParser.cpp` for examples.
In current implementation, it will ignore unrecognized extensions. It intends to skip 'x1p0' and recognizes 'm2p0' and decodes `mul` instruction correctly. So, I think it is appropriate to create this test case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75833/new/

https://reviews.llvm.org/D75833