[PATCH] D75993: [Target][ARM] Improvements to the VPT Block Insertion Pass

Pierre van Houtryve via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 12 03:03:23 PDT 2020


Pierre-vh added a comment.

In D75993#1918007 <https://reviews.llvm.org/D75993#1918007>, @dmgreen wrote:

> Good to see this getting updated.
>
> Does this handle predicates like TET/TEET/etc, where we go back to a Then predicate?  Any instruction that defs the VPR should reset us back to a Then (so a VCMP will reset the predicate to Then for subsequent instructions in the block). Obviously a VPNOT can flip back to Then too.
>
> Can you make sure we have tests for those situations? Best bet nowadays would probably be to use instrinsics to create some interesting testcases.


This was not a goal for this initial patch, I just focused on handling else blocks. 
However, this is certainly something I can do if you want, but it should it be part of this patch or another patch?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75993/new/

https://reviews.llvm.org/D75993





More information about the llvm-commits mailing list