[PATCH] D75993: [Target][ARM] Improvements to the VPT Block Insertion Pass

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 11 14:07:35 PDT 2020


dmgreen added a comment.

Good to see this getting updated.

Does this handle predicates like TET/TEET/etc, where we go back to a Then predicate?  Any instruction that defs the VPR should reset us back to a Then (so a VCMP will reset the predicate to Then for subsequent instructions in the block). Obviously a VPNOT can flip back to Then too.

Can you make sure we have tests for those situations? Best bet nowadays would probably be to use instrinsics to create some interesting testcases.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75993/new/

https://reviews.llvm.org/D75993





More information about the llvm-commits mailing list