[PATCH] D75857: [AMDGPU] Fix using physical registers in vector instructions

Sebastian Neubauer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 12 00:52:37 PDT 2020


Flakebi added a comment.

In D75857#1917137 <https://reviews.llvm.org/D75857#1917137>, @arsenm wrote:

> I still think theses should not be seeing physical register operands, and it would be better to fix this by avoiding that situation


Why is introducing a copy a better fix? And does this mean I should return a COPY when doing `(ballot 1) -> EXEC/EXEC_LO` here? https://reviews.llvm.org/D65088#C1855323NL8643

Wouldn’t a copy use an SGPR and increase the SGPR-count? Then we would generate less optimal code, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75857/new/

https://reviews.llvm.org/D75857





More information about the llvm-commits mailing list