[PATCH] D75438: [X86] Reduce the number of emitted fragments due to branch align

Wed Mar 11 21:50:26 PDT 2020

reames requested changes to this revision.
reames added inline comments.
This revision now requires changes to proceed.

================
Comment at: llvm/test/MC/X86/align-branch-64-negative.s:30
   # the return address of the call.
-  # CHECK: labeled_call_test2:
-  # CHECK: 5a: callq
-  # CHECK: 5f: nop
-  # CHECK: 60 label_after
-  # CHECK: 60: jmp
+##  # check: labeled_call_test2:
+##  # check: 5a: callq
----------------
skan wrote:
> MaskRay wrote:
> > Why is the test deleted?
> This test is a negative test and we expect the label is bounded to the end of the call rather than the start of the jmp.  As commented in this test file, the label "label_after" is in the right place now because we insert a new empty DataFragment after the call.
Please update the check line instead.  I can't tell from the diff or not whether the change made is correct or not.

p.s. Commenting out a test is almost never the right answer.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75438/new/

https://reviews.llvm.org/D75438