[PATCH] D75438: [X86] Reduce the number of emitted fragments due to branch align

Tue Mar 10 23:00:29 PDT 2020

skan marked an inline comment as done.
skan added inline comments.

================
Comment at: llvm/test/MC/X86/align-branch-64-negative.s:30
   # the return address of the call.
-  # CHECK: labeled_call_test2:
-  # CHECK: 5a: callq
-  # CHECK: 5f: nop
-  # CHECK: 60 label_after
-  # CHECK: 60: jmp
+##  # check: labeled_call_test2:
+##  # check: 5a: callq
----------------
MaskRay wrote:
> Why is the test deleted?
This test is a negative test and we expect the label is bounded to the end of the call rather than the start of the jmp.  As commented in this test file, the label "label_after" is in the right place now because we insert a new empty DataFragment after the call.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75438/new/

https://reviews.llvm.org/D75438