[PATCH] D75939: [x86][seses] Introduce SESES pass for LVI

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Haven't looked into the code, but some suggestions for the test. Insignificant parts should be deleted. For example, .note.GNU-stack is not needed. If the codegen has nothing to do with CFI, .cfi_startproc and .cfi_endproc should be omitted. I added `.Lfoo$local` as a dso_local related assembler/linker optimization. It should be omitted. Tricky code sequence in the assembly should be documented. A file level comments helps readers understand what the test is about.



================
Comment at: llvm/test/CodeGen/X86/speculative-execution-side-effect-suppression.ll:161
+; CHECK:                                        # -- End function
+; CHECK: .section ".note.GNU-stack","", at progbits
----------------
.note.GNU-stack is not needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75939/new/

https://reviews.llvm.org/D75939