[PATCH] D75269: [AssumeBundles] Enforce constraints on the operand bundle of llvm.assume

[Tyker via Phabricator via llvm-commits]

Tyker marked an inline comment as done.
Tyker added inline comments.


================
Comment at: llvm/lib/IR/Verifier.cpp:4326
+      Assert(Attribute::isExistingAttribute(Elem.Tag->getKey()),
+             "tags must be valid attribute names");
+      Assert(Elem.End - Elem.Begin <= 2, "to many arguments");
----------------
jdoerfert wrote:
> When we drop uses, should we go to `none` as a tag so it is actually a valid attribute or do we want to allow a special tag here?
in D73404 i named the tag to "ignore" and adapted the verifier to treat is as valid.
but putting a "none" could be another solution if it is a valid attribute.
but it doesn't seem to be considered as a valid by opt and isn't considered valid by isExistingAttribute. it is just the hard coded first value of the enum.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75269/new/

https://reviews.llvm.org/D75269