[PATCH] D75269: [AssumeBundles] Enforce constraints on the operand bundle of llvm.assume

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 10 12:00:45 PDT 2020


jdoerfert added inline comments.


================
Comment at: llvm/lib/IR/Verifier.cpp:4326
+      Assert(Attribute::isExistingAttribute(Elem.Tag->getKey()),
+             "tags must be valid attribute names");
+      Assert(Elem.End - Elem.Begin <= 2, "to many arguments");
----------------
When we drop uses, should we go to `none` as a tag so it is actually a valid attribute or do we want to allow a special tag here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75269/new/

https://reviews.llvm.org/D75269





More information about the llvm-commits mailing list