[PATCH] D75831: [mlir][Linalg] Revisit 0-D abstraction

[Uday Bondhugula via Phabricator via llvm-commits]

bondhugula added inline comments.


================
Comment at: mlir/include/mlir/IR/AffineMap.h:47
 
+  /// Returns a zero result affine map with `dimCount` dim and no symbols:
+  ///   (...) -> ().
----------------
dim -> dimensions


================
Comment at: mlir/lib/IR/AffineMap.cpp:365
+  return numDims == 0 ? AffineMap::get(maps.front().getContext())
+                      : AffineMap::get(numDims, 0, results);
 }
----------------
/*numSymbols=*/0


================
Comment at: mlir/lib/IR/AffineMap.cpp:365
+  return numDims == 0 ? AffineMap::get(maps.front().getContext())
+                      : AffineMap::get(numDims, 0, results);
 }
----------------
bondhugula wrote:
> /*numSymbols=*/0
How do you know whether results is non-empty here? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75831/new/

https://reviews.llvm.org/D75831