[PATCH] D75831: [mlir][Linalg] Revisit 0-D abstraction
Uday Bondhugula via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 10 07:32:19 PDT 2020
bondhugula requested changes to this revision.
bondhugula added inline comments.
This revision now requires changes to proceed.
================
Comment at: mlir/include/mlir/IR/AffineMap.h:49
+ /// (...) -> ().
+ static AffineMap get(MLIRContext *context, unsigned dimCount);
+
----------------
We could just go for for:
```
static AffineMap get(unsigned dimCount, unsigned symCount, MLIRContext *context);
```
In any case, please have context appear last to be consistent with everything else.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75831/new/
https://reviews.llvm.org/D75831
More information about the llvm-commits
mailing list