[PATCH] D75742: [Object] Support large archive members

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

  Command Output (stderr):
  --
  
  bzip2: Compressed file ends unexpectedly;
  	perhaps it is corrupted?  *Possible* reason follows.
  bzip2: Success
  	Input file = /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/lld/test/ELF/Inputs/large-files1.o.bz2, output file = (stdout)
  
  It is possible that the compressed file(s) have become corrupted.
  You can use the -tvv option to test integrity of such files.
  
  You can use the `bzip2recover' program to attempt to recover
  data from undamaged sections of corrupted files.

As you see, many systems may not be able to run such tests. Deleting the test may be fine.



================
Comment at: llvm/lib/Object/Archive.cpp:396
   if (Parent->IsThin) {
-    Expected<uint32_t> Size = Header.getSize();
+    Expected<uint64_t> Size = Header.getSize();
     if (!Size)
----------------
Does `return Header.getSize()` work?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75742/new/

https://reviews.llvm.org/D75742