[PATCH] D75742: [Object] Support large archive members

[James Henderson via Phabricator via llvm-commits]

jhenderson created this revision.
jhenderson added reviewers: ruiu, MaskRay, grimar, rupprecht.
Herald added subscribers: hiraditya, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.

The archive library truncated the size of archive members whose size was greater than max uint32_t, leading to errors in tools that use the library. This patch fixes the issue and adds a test to LLD to show that LLD can handle large files.

The test isn't ideal, and I'm open to suggestions on alternative methods of testing. It includes two zipped-up files of a little over 2GB in size each, and the test iteslf takes up to 2 minutes on my machine to run, and uses a maximum of a little over 8GB at runtime.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D75742

Files:
  lld/test/ELF/Inputs/large-files1.o.bz2
  lld/test/ELF/Inputs/large-files2.o.bz2
  lld/test/ELF/large-files.s
  llvm/lib/Object/Archive.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75742.248721.patch
Type: text/x-patch
Size: 3979 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200306/ba04646c/attachment-0001.bin>