[PATCH] D75305: [AIX] Handle LinkOnceODRLinkage and AppendingLinkage for static init gloabl arrays
Xiangling Liao via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 6 06:37:43 PST 2020
This revision was automatically updated to reflect the committed changes.
Closed by commit rG362456bc5359: [AIX] Handle LinkOnceODRLinkage and AppendingLinkage for static init gloabl… (authored by Xiangling_L).
Changed prior to commit:
https://reviews.llvm.org/D75305?vs=248564&id=248718#toc
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75305/new/
https://reviews.llvm.org/D75305
Files:
llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
llvm/test/CodeGen/PowerPC/aix-AppendingLinkage.ll
llvm/test/CodeGen/PowerPC/aix-LinkOnceODRLinkage.ll
Index: llvm/test/CodeGen/PowerPC/aix-LinkOnceODRLinkage.ll
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/PowerPC/aix-LinkOnceODRLinkage.ll
@@ -0,0 +1,13 @@
+; RUN: llc -mtriple powerpc-ibm-aix-xcoff < %s | \
+; RUN: FileCheck %s
+
+; RUN: llc -mtriple powerpc64-ibm-aix-xcoff < %s | \
+; RUN: FileCheck %s
+
+define linkonce_odr void @_Z3fooIiEvT_() {
+entry:
+ ret void
+}
+
+; CHECK: .weak _Z3fooIiEvT_
+; CHECK: .weak ._Z3fooIiEvT_
Index: llvm/test/CodeGen/PowerPC/aix-AppendingLinkage.ll
===================================================================
--- /dev/null
+++ llvm/test/CodeGen/PowerPC/aix-AppendingLinkage.ll
@@ -0,0 +1,21 @@
+; RUN: llc -verify-machineinstrs -mcpu=pwr4 -mtriple powerpc-ibm-aix-xcoff < \
+; RUN: %s | FileCheck %s
+
+; RUN: llc -verify-machineinstrs -mcpu=pwr4 -mtriple powerpc64-ibm-aix-xcoff < \
+; RUN: %s | FileCheck %s
+
+ at llvm.global_ctors = appending global [1 x { i32, void ()*, i8* }] [{ i32, void ()*, i8* } { i32 65535, void ()* @foo, i8* null }]
+ at llvm.global_dtors = appending global [1 x { i32, void ()*, i8* }] [{ i32, void ()*, i8* } { i32 65535, void ()* @bar, i8* null }]
+
+define dso_local void @foo() {
+entry:
+ ret void
+}
+
+define dso_local void @bar() {
+entry:
+ ret void
+}
+
+; CHECK-NOT: llvm.global_ctors
+; CHECK-NOT: llvm.global_dtors
Index: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
===================================================================
--- llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
+++ llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
@@ -1579,9 +1579,22 @@
return PPCAsmPrinter::lowerConstant(CV);
}
+static bool isSpecialLLVMGlobalArrayForStaticInit(const GlobalVariable *GV) {
+ return StringSwitch<bool>(GV->getName())
+ .Cases("llvm.global_ctors", "llvm.global_dtors", true)
+ .Default(false);
+}
+
void PPCAIXAsmPrinter::emitGlobalVariable(const GlobalVariable *GV) {
ValidateGV(GV);
+ // TODO: Update the handling of global arrays for static init when we support
+ // the ".ref" directive.
+ // Otherwise, we can skip these arrays, because the AIX linker collects
+ // static init functions simply based on their name.
+ if (isSpecialLLVMGlobalArrayForStaticInit(GV))
+ return;
+
// Create the symbol, set its storage class.
MCSymbolXCOFF *GVSym = cast<MCSymbolXCOFF>(getSymbol(GV));
GVSym->setStorageClass(
Index: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
===================================================================
--- llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
+++ llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
@@ -1948,7 +1948,11 @@
case GlobalValue::CommonLinkage:
return XCOFF::C_EXT;
case GlobalValue::ExternalWeakLinkage:
+ case GlobalValue::LinkOnceODRLinkage:
return XCOFF::C_WEAKEXT;
+ case GlobalValue::AppendingLinkage:
+ report_fatal_error(
+ "There is no mapping that implements AppendingLinkage for XCOFF.");
default:
report_fatal_error(
"Unhandled linkage when mapping linkage to StorageClass.");
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75305.248718.patch
Type: text/x-patch
Size: 3077 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200306/27077401/attachment.bin>
More information about the llvm-commits
mailing list