[PATCH] D75352: Add rsqrt op to Standard dialect and lower it to LLVM dialect.

[Adrian Kuegel via Phabricator via llvm-commits]

akuegel marked an inline comment as done.
akuegel added inline comments.


================
Comment at: mlir/lib/Conversion/StandardToLLVM/ConvertStandardToLLVM.cpp:1676
+    auto operandType =
+        transformed.operand().getType().dyn_cast_or_null<LLVM::LLVMType>();
+
----------------
rriddle wrote:
> Don't use dyn_cast_or_null here, the result of `getType` is never null. Use dyn_cast if you know the input is non-null.
Thanks for the suggestion :)
I made that part of a refactoring CL that I was planning to do, anyway: https://reviews.llvm.org/D75733


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75352/new/

https://reviews.llvm.org/D75352