[PATCH] D75352: Add rsqrt op to Standard dialect and lower it to LLVM dialect.

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 5 10:58:10 PST 2020


rriddle added inline comments.


================
Comment at: mlir/lib/Conversion/StandardToLLVM/ConvertStandardToLLVM.cpp:1676
+    auto operandType =
+        transformed.operand().getType().dyn_cast_or_null<LLVM::LLVMType>();
+
----------------
Don't use dyn_cast_or_null here, the result of `getType` is never null. Use dyn_cast if you know the input is non-null.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75352/new/

https://reviews.llvm.org/D75352





More information about the llvm-commits mailing list