[PATCH] D75485: Support DW_FORM_strx* in llvm-dwp.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/tools/llvm-dwp/llvm-dwp.cpp:165-168
+  while (Offset < HeaderSize) {
+    auto Byte = Data.getU8(&Offset);
+    Out.emitFill(1, Byte);
+  }
----------------
This should probably be:
```
Out.emitBytes(Data.getBytes(&Offset, HeaderSize));
```
I think?



================
Comment at: llvm/tools/llvm-dwp/llvm-dwp.cpp:262-263
   while ((Name = AbbrevData.getULEB128(&AbbrevOffset)) |
-         (Form = static_cast<dwarf::Form>(AbbrevData.getULEB128(&AbbrevOffset))) &&
+             (Form = static_cast<dwarf::Form>(
+                  AbbrevData.getULEB128(&AbbrevOffset))) &&
          (Name != 0 || Form != 0)) {
----------------
unnecessary reformatting, maybe?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75485/new/

https://reviews.llvm.org/D75485