[PATCH] D75485: Support DW_FORM_strx* in llvm-dwp.

[Ali Tamur via Phabricator via llvm-commits]

tamur updated this revision to Diff 248361.
tamur marked an inline comment as not done.
tamur added a comment.

- Introduce a CompileUnitHeader structure, it is needed to know the dwarf version, because, for example, debug_str_offsets sectoins have a header only when dwarf version is 5.
- Introduce a function to parse CompileUnitHeader.
- Introduce a function to compute the size of debug_str_offsets section headers.
- Fix writeStringsAndOffsets to copy debug_str_offsets section headers correctly.
- Get getIndexedString funciton to handle DW_FORM_strx forms correctly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75485/new/

https://reviews.llvm.org/D75485

Files:
  llvm/test/tools/llvm-dwp/Inputs/handle_strx/main.dwo
  llvm/test/tools/llvm-dwp/X86/handle_strx.test
  llvm/test/tools/llvm-dwp/X86/invalid_string_form.test
  llvm/tools/llvm-dwp/llvm-dwp.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75485.248361.patch
Type: text/x-patch
Size: 11645 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200305/74cb5472/attachment.bin>