[PATCH] D75536: [LLD] Add support for --unique option

[Dave Bozier via Phabricator via llvm-commits]

davidb marked an inline comment as done.
davidb added inline comments.


================
Comment at: lld/test/ELF/unique-orphans.s:25
+# RUN: ld.lld %t1.o %t2.o -r -o %t3.ro --unique
+# RUN: objdump -h %t3.ro | FileCheck --check-prefix UNIQUE %s
+# UNIQUE-COUNT-2: .text.foo
----------------
MaskRay wrote:
> MaskRay wrote:
> > Check sections with `llvm-readelf -S`, instead of `objdump` (may not even be installed)
> Not done. Use `llvm-readelf -S`
I added the `llvm-`prefix so it should pick the right objdump. There are 2x more uses of `llvm-objdump` than readelf in the lld test suite, 4x more in LLVM as a whole. What is the motivation for readelf?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75536/new/

https://reviews.llvm.org/D75536