[PATCH] D75536: [LLD] Add support for --unique option

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/unique-orphans.s:25
+# RUN: ld.lld %t1.o %t2.o -r -o %t3.ro --unique
+# RUN: objdump -h %t3.ro | FileCheck --check-prefix UNIQUE %s
+# UNIQUE-COUNT-2: .text.foo
----------------
MaskRay wrote:
> Check sections with `llvm-readelf -S`, instead of `objdump` (may not even be installed)
Not done. Use `llvm-readelf -S`


================
Comment at: lld/test/ELF/unique-orphans.s:25
+
+# RUN: echo 'SECTIONS { .foo : { *(.foo) }}' > %t.script
+# RUN: ld.lld %t.o -o %t2.elf -T %t.script --unique 
----------------
Add a comment, along the lines of

`## Test that --unique does not affect sections specified in output section descriptions.`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75536/new/

https://reviews.llvm.org/D75536