[PATCH] D75647: [llvm-readobj] Include section name of notes.
Jordan Rupprecht via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 4 19:03:37 PST 2020
rupprecht updated this revision to Diff 248368.
rupprecht marked 2 inline comments as done.
rupprecht added a comment.
- Update test comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75647/new/
https://reviews.llvm.org/D75647
Files:
llvm/test/tools/llvm-readobj/ELF/gnu-notes.test
Index: llvm/test/tools/llvm-readobj/ELF/gnu-notes.test
===================================================================
--- llvm/test/tools/llvm-readobj/ELF/gnu-notes.test
+++ llvm/test/tools/llvm-readobj/ELF/gnu-notes.test
@@ -59,7 +59,8 @@
# LLVM-NEXT: }
# LLVM-NEXT: ]
-## Note: there is no "Name: .note.gnu.build-id" assertion here because it is stripped.
+## Note: there is no "Name: .note.gnu.build-id" assertion here because the
+## section header table is not present.
# LLVM-STRIPPED: Notes [
# LLVM-STRIPPED-NEXT: NoteSection {
# LLVM-STRIPPED-NEXT: Offset: 0x78
@@ -73,7 +74,8 @@
# LLVM-STRIPPED-NEXT: }
# LLVM-STRIPPED-NEXT: ]
-## Note: offset and length printed instead of "found in: .note.gnu.build-id" because it is stripped.
+## Note: offset and length printed instead of "found in: .note.gnu.build-id"
+## because the section header table is not present.
# GNU-STRIPPED:Displaying notes found at file offset 0x00000078 with length 0x00000020:
# GNU-STRIPPED-NEXT: Owner Data size Description
# GNU-STRIPPED-NEXT: GNU 0x00000010 NT_GNU_BUILD_ID (unique build ID bitstring)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75647.248368.patch
Type: text/x-patch
Size: 1161 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200305/de759525/attachment.bin>
More information about the llvm-commits
mailing list