[PATCH] D75647: [llvm-readobj] Include section name of notes.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 4 15:11:41 PST 2020


MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/gnu-notes.test:64
 # LLVM-STRIPPED-NEXT:   NoteSection {
 # LLVM-STRIPPED-NEXT:     Offset: 0x78
 # LLVM-STRIPPED-NEXT:     Size: 0x20
----------------
Worth a comment that it has no name.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/gnu-notes.test:75
 
 #      GNU-STRIPPED:Displaying notes found at file offset 0x00000078 with length 0x00000020:
 # GNU-STRIPPED-NEXT:  Owner                Data size 	Description
----------------
This will be the remaining test for the `Displaying notes found at file offset ... ` form.

Worth a comment that it has no name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75647/new/

https://reviews.llvm.org/D75647





More information about the llvm-commits mailing list