[PATCH] D75590: [Attributor] IPO across definition boundary of a function marked alwaysinline

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:1726
   }
 
   /// See AbstractAttribute::manifest(...).
----------------
If `!FnScope` is true, `FnScope` is null. We need to cache the `isInlineViable` result.


================
Comment at: llvm/test/Transforms/Attributor/alwaysinline.ll:78
+  ret i32 %add
+}
----------------
You need check and check-not lines to make sure we do not derive function attributes where we should not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75590/new/

https://reviews.llvm.org/D75590