[PATCH] D75590: [Attributor] IPO across definition boundary of a function marked alwaysinline

[Luofan Chen via Phabricator via llvm-commits]

bbn marked an inline comment as done.
bbn added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:1717
+    if (IsFnInterface && (!FnScope || !FnScope->hasExactDefinition())) {
+      if (FnScope->hasFnAttribute(Attribute::AlwaysInline)) {
+        // check if it is OK to inline, if so, do fix-point analysis for the
----------------
uenoku wrote:
> Is `FnScope` always nonnull here?
I think so, because the outer if has judgement: `if(!FnScope || !FnScope->hasExactDefinition())`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75590/new/

https://reviews.llvm.org/D75590