[PATCH] D75405: [LSR] OptimizeShadowIV: Constant can be negative

[Stefanos Baziotis via Phabricator via llvm-commits]

baziotis added subscribers: xbolva00, sunfish.
baziotis added a comment.

In D75405#1901627 <https://reviews.llvm.org/D75405#1901627>, @baziotis wrote:

>   ; LSR previously eliminated the sitofp by introducing an induction
>   ; variable which stepped by a bogus ((double)UINT32_C(-1)). It's theoretically
>   ; possible to eliminate the sitofp using a proper -1.0 step though; this
>   ; test should be changed if that is done.
>
>
> I haven't seen that comment in `llvm/test/CodeGen/X86/negative-stride-fptosi-user.ll`. Apparently people have thought about that,
>  unfortunately the codegen is not better.


@sunfish and @xbolva00 you're the 2 people involved in this test as I can see in the Git blame. I think your opinion is important.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75405/new/

https://reviews.llvm.org/D75405