[PATCH] D75405: [LSR] OptimizeShadowIV: Constant can be negative

Stefanos Baziotis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 2 12:29:29 PST 2020


baziotis added a comment.

  ; LSR previously eliminated the sitofp by introducing an induction
  ; variable which stepped by a bogus ((double)UINT32_C(-1)). It's theoretically
  ; possible to eliminate the sitofp using a proper -1.0 step though; this
  ; test should be changed if that is done.

I haven't seen that comment in `llvm/test/CodeGen/X86/negative-stride-fptosi-user.ll`. Apparently people have thought about that,
unfortunately the codegen is not better.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75405/new/

https://reviews.llvm.org/D75405





More information about the llvm-commits mailing list