[PATCH] D75172: [obj2yaml] - Split sections dumping to a new ELFDumper<ELFT>::dumpSections() method.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: llvm/tools/obj2yaml/elf2yaml.cpp:232
 
+  if (auto ChunksOrErr = dumpSections())
+    Y->Chunks = std::move(*ChunksOrErr);
----------------
jhenderson wrote:
> I feel like this is probably a violation of our policy on `auto` as it's not clear from the line of code what type `ChunksOrErr` is.
Expand to `Expected<std::vector<std::unique_ptr<ELFYAML::Chunk>>>`

It should fit on one line.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75172/new/

https://reviews.llvm.org/D75172