[PATCH] D75172: [obj2yaml] - Split sections dumping to a new ELFDumper<ELFT>::dumpSections() method.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Personally, I prefer lots of smaller functions, even if they are just chaining into one another, so LGTM (with nit). Might want to let @MaskRay have more time to respond though.



================
Comment at: llvm/tools/obj2yaml/elf2yaml.cpp:232
 
+  if (auto ChunksOrErr = dumpSections())
+    Y->Chunks = std::move(*ChunksOrErr);
----------------
I feel like this is probably a violation of our policy on `auto` as it's not clear from the line of code what type `ChunksOrErr` is.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75172/new/

https://reviews.llvm.org/D75172