[PATCH] D75337: [debuginfo-tests][dexter] Add _verify_options to TestToolBase
Stephen Tozer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 2 09:30:16 PST 2020
StephenTozer added a comment.
In D75337#1901253 <https://reviews.llvm.org/D75337#1901253>, @StephenTozer wrote:
> Actually, after looking at how this is being used in the child revisions, it looks like this should be folded into `handle_options`
Just to clarify (since I realise this is ambiguous) I think the `_verify_options` logic in the child revisions should be folded into `handle_options`, raising Errors instead of returning False, and this revision can be shelved since it's otherwise unnecessary.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75337/new/
https://reviews.llvm.org/D75337
More information about the llvm-commits
mailing list