[PATCH] D75337: [debuginfo-tests][dexter] Add _verify_options to TestToolBase
Stephen Tozer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 2 09:30:11 PST 2020
StephenTozer added a comment.
Actually, after looking at how this is being used in the child revisions, it looks like this should be folded into `handle_options` - that function is already used to check whether the supplied options to a tool are valid, and raises an Error if not. That seems more consistent with the rest of Dexter than returning a ReturnCode.FAIL, which is currently only used if the test is run without any errors but has a failing score.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75337/new/
https://reviews.llvm.org/D75337
More information about the llvm-commits
mailing list