[PATCH] D74651: Add IR constructs for inalloca replacement llvm.call.setup

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

I would add a test to llvm/test/Bitcode/attributes.ll for preallocated. Other than that, I think we can assume that the attribute machinery works, and we don't need dedicated round-trip testing like we did for inalloca (llvm/test/(Assembler|Bitcode)/inalloca.ll).

I basically think this looks good, but I think we need rules in llvm/docs/LangRef.rst before landing this, which means we need to wrap up the discussion on llvm-dev with Eli.



================
Comment at: llvm/include/llvm/Bitcode/LLVMBitCodes.h:636
   ATTR_KIND_SANITIZE_MEMTAG = 64,
+  ATTR_KIND_PREALLOCATED = 65,
 };
----------------
This set off my "is this used as the RHS of a left shift?" spidey sense, but I checked, and I think it's all good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74651/new/

https://reviews.llvm.org/D74651