[PATCH] D75030: [AMDGPU] Use conservative defaults for XNACK/SRAM ECC

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 28 07:30:14 PST 2020


scott.linder added a reviewer: scott.linder.
scott.linder added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:753
+   FeatureCodeObjectV3,
+   FeatureXNACK]>;
 
----------------
Could you also include an update to processors table in llvm/docs/AMDGPUUsage.rst for all the changing defaults? It is currently wrong anyway because we forbid XNACK on some targets, but if we are fixing things it would be good to fix it as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75030/new/

https://reviews.llvm.org/D75030





More information about the llvm-commits mailing list