[PATCH] D75030: [AMDGPU] Use conservative defaults for XNACK/SRAM ECC
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 24 10:02:58 PST 2020
rampitec added a comment.
Maybe extract AMDGPU.td changes into a separate patch for the time being? These seem safe.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp:155
+ if (FS.contains("+xnack"))
+ report_fatal_error("XNACK was requested for a processor that does not support it!");
+
----------------
That's a right thing to do, but I suppose needs some testing and fixing at least known apps doing so before we can submit.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75030/new/
https://reviews.llvm.org/D75030
More information about the llvm-commits
mailing list