[PATCH] D75273: [entry values] ARM: Add a describeLoadedValue override (PR45025)

David Stenberg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 28 04:13:29 PST 2020


dstenb added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:1043-1044
+    //
+    // We'd like to describe the call site value of d0 as d8, but this requires
+    // gathering and merging the descriptions for the two VMOVS instructions.
+    //
----------------
This is a problem we're having for our downstream target also, as parameters may be produced by bundled instructions modifying different parts of the register. I have thought a bit about adding an optional Fragment or SubReg field to ParamLoadedValue, to specify which part of the register that was described, and let `collectCallSiteParameters()` keep the parameter in the worklist until all parts have been described, but I have not really thought more about how that could be implemented.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75273/new/

https://reviews.llvm.org/D75273





More information about the llvm-commits mailing list