[PATCH] D75273: [entry values] ARM: Add a describeLoadedValue override (PR45025)
Djordje Todorovic via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 27 23:35:42 PST 2020
djtodoro accepted this revision.
djtodoro added a comment.
LGTM, thanks! (nits included)
================
Comment at: llvm/test/DebugInfo/MIR/ARM/call-site-info-vmovd.mir:40
+ declare void @llvm.dbg.value(metadata, metadata, metadata)
+ declare void @llvm.stackprotector(i8*, i8**)
+
----------------
This is unused, so we can delete it.
================
Comment at: llvm/test/DebugInfo/MIR/ARM/call-site-info-vmovd.mir:71
+ !22 = !DILocation(line: 0, scope: !16)
+ !23 = !DILocation(line: 3, column: 3, scope: !16)
+ !24 = !DILocation(line: 4, column: 5, scope: !16)
----------------
We can attach only to !23.
================
Comment at: llvm/test/DebugInfo/MIR/ARM/call-site-info-vmovd.mir:80
+alignment: 2
+exposesReturnsTwice: false
+legalized: false
----------------
We do not need all these MF attributes (I think only 'name' and 'callSites').
================
Comment at: llvm/test/DebugInfo/MIR/ARM/call-site-info-vmovs.mir:68
+alignment: 2
+exposesReturnsTwice: false
+legalized: false
----------------
We do not need all these MF attributes (I think only 'name' and 'callSites').
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75273/new/
https://reviews.llvm.org/D75273
More information about the llvm-commits
mailing list