[PATCH] D75221: [MLIR] Refactor handling of dialect libraries

[Stephen Neuendorffer via Phabricator via llvm-commits]

stephenneuendorffer marked an inline comment as done.
stephenneuendorffer added inline comments.


================
Comment at: mlir/cmake/modules/AddMLIR.cmake:56
+  add_llvm_library(${ARGV})
+endfunction(add_mlir_dialect_library)
----------------
mehdi_amini wrote:
> Did you need to separate the `add_mlir_dialect` from `add_mlir_dialect_library` because some of them don't use `add_mlir_dialect` / don't have an entry in the include directory? Otherwise why not setting the MLIR_DIALECT_LIBS property in the `add_mlir_dialect` function?
It does seem odd at first sight, but in the current scheme, there are multiple libraries for some dialects, so it's not a 1:1 relationship..   Even if there was a 1:1 relationship it seems odd to me that a declaration about a library shows up in the include directory.  This way is consistent with the corresponding change for Conversions, and I think a similar scheme could be done for Transforms. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75221/new/

https://reviews.llvm.org/D75221