[PATCH] D75221: [MLIR] Refactor handling of dialect libraries

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: mlir/cmake/modules/AddMLIR.cmake:56
+  add_llvm_library(${ARGV})
+endfunction(add_mlir_dialect_library)
----------------
Did you need to separate the `add_mlir_dialect` from `add_mlir_dialect_library` because some of them don't use `add_mlir_dialect` / don't have an entry in the include directory? Otherwise why not setting the MLIR_DIALECT_LIBS property in the `add_mlir_dialect` function?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75221/new/

https://reviews.llvm.org/D75221