[PATCH] D74023: [RISCV] ELF attribute section for RISC-V

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D74023#1895884 <https://reviews.llvm.org/D74023#1895884>, @HsiangKai wrote:

> Hi @MaskRay, I know you have a patch to refactor ARMAttributeParser in D75015 <https://reviews.llvm.org/D75015>.
>  If you have no other comments in this patch, do you mind let this patch upstream first and refactor ARMAttributeParser based on it?


I created D75015 <https://reviews.llvm.org/D75015> because I thought

- it would be more likely accepted before D74023 <https://reviews.llvm.org/D74023>. I am of the belief that new code does not have to start using `VariableName`.
- Doing D75015 <https://reviews.llvm.org/D75015> before D4023 <https://reviews.llvm.org/D4023> can minimize the changes on the RISC-V side. (No future `void` -> `Error`. Better error reporting.)



================
Comment at: llvm/test/MC/RISCV/invalid-attribute.s:10
+.attribute arch, "foo"
+# CHECK: [[@LINE-1]]:{{[0-9]+}}: error: bad arch string foo
+
----------------
Write the column number explicitly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74023/new/

https://reviews.llvm.org/D74023