[PATCH] D74023: [RISCV] ELF attribute section for RISC-V

Hsiangkai Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 27 09:40:26 PST 2020


HsiangKai marked an inline comment as done.
HsiangKai added inline comments.


================
Comment at: lld/test/ELF/riscv-attributes.s:1
+# REQUIRES: riscv
+
----------------
MaskRay wrote:
> I suggest not making changes to `lld/test/ELF` for this patch. The changes can be made in a follow-up patch.
Do you mean there is no need to add a test case for lld in this patch? Indeed, I have no modification for lld. I just want to ensure the patch will not broken lld.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74023/new/

https://reviews.llvm.org/D74023





More information about the llvm-commits mailing list